Randomness requirements following W3C Trace Context level 2 #4162
Conversation
jmacd
changed the title
jmacd
changed the title
jmacd
force-pushed
the
jmacd/sampling_new
branch
from
fa9ec4c
to
71750cd
Compare
…ication into jmacd/sampling_new
Thanks Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Kent Quirk <[email protected]>
…pecification into jmacd/sampling_new
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…ication into jmacd/sampling_new
…ication into jmacd/sampling_new
|
Overall LGTM (once some of the latest feedback comments have been addressed). |
Co-authored-by: Trask Stalnaker <[email protected]>
…pecification into jmacd/sampling_new
…ication into jmacd/sampling_new
specification/trace/sdk.md
Outdated
| meet the [W3C Trace Context Level 2 randomness requirements][W3CCONTEXTTRACEID], | ||
| and when the the [`rv` sub-key of the OpenTelemetry TraceState][OTELRVALUE] is | ||
| not already set, the SDK SHOULD insert an explicit trace randomness value | ||
| into the OpenTelemetry TraceState value containing 56 random bits. |
There was a problem hiding this comment.
This requirement seems to conflict with the use case where we want to have the same rv shared by a number of related traces. Also, it makes the random flag in trace-flags quite meaningless.
We may want to allow samplers to change the rv for the ROOT spans explicitly, or delegate the responsibility for setting rv for non-random trace-id and ROOT spans to the samplers.
There was a problem hiding this comment.
@PeterF778 See if b75113c addresses your concern. I'm trying to avoid a large diff, and I think this is sufficient.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…ication into jmacd/sampling_new
…s are not required to. Built-in samplers are not required to.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…ication into jmacd/sampling_new
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Changes
Updates Trace SDK and Propagator specifications with
Part of #1413.
Part of #3602.
Product of the Sampling SIG members @kentquirk @kalyanaj @oertl @PeterF778 and myself.
CHANGELOG.mdspec-compliance-matrix.md